Skip to content

Namespace cleanup#273

Closed
gtback wants to merge 14 commits intomasterfrom
namespace-cleanup
Closed

Namespace cleanup#273
gtback wants to merge 14 commits intomasterfrom
namespace-cleanup

Conversation

@gtback
Copy link
Contributor

@gtback gtback commented Jul 14, 2015

DO NOT MERGE!

I'm just opening a pull request so we can talk about things in this branch.

gtback added 13 commits July 9, 2015 15:34
bworrell
bworrell reviewed Jul 16, 2015
View reviewed changes
stix/utils/nsparser.py
Copy link
Contributor

@bworrell bworrell Jul 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could just move this after the DEFAULT_STIX_PREFIX_TO_NAMESPACE assignment below, and use that to create this dictionary?

Copy link
Contributor Author

@gtback gtback Jul 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STIX_NAMESPACES is just the stix.mitre.org and data-marking.mitre.org namespaces (not CybOX, MAEC, Extensions, etc.). It's used in the STIX core binding, otherwise we can just get rid of it entirely (I didn't look into how it's used there.)

@bworrell
Copy link
Contributor

bworrell commented Jul 16, 2015

So far this is looking pretty cool to me! I'm wondering if NamespaceInfo should be moved to mixbox and generalized a bit. It has a _BASELINE_NAMESPACES class attribute which contains namespaces that CybOX/MAEC don't care about.

Then mixbox.Entity could be refactored to use NamespaceInfo for namespace gathering. I think it'd be awesome if we could define one approach namespace/schemalocation collection for all the APIs to use.

@gtback
Copy link
Contributor Author

gtback commented Jul 16, 2015

Yes, ultimately NamespaceInfo should be moved to mixbox. There's some overlap with the functionality I was intending for NamespaceSet, and was on the fence about whether to merge them together or keep them separate.

Entity should be modified to use NamespaceInfo (either directly or as part of EntityParser). Getting the code out of python-stix and into mixbox is the first step.

@landscape-bot
Copy link

landscape-bot commented Jul 17, 2015

Code Health
Repository health decreased by 9% when pulling a08cb12 on namespace-cleanup into 8618b0f on master.

@chisholm chisholm closed this Apr 26, 2016
@chisholm chisholm deleted the namespace-cleanup branch April 26, 2016 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gtback @bworrell @landscape-bot @chisholm